Make layer_predict forward stored dots_list to predict()
#358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajmcdon
approved these changes
Jul 9, 2024
We were missing `type` and `opts` in documentation because they weren't in the signature of `predict.epi_workflow`, not because of an issue with `predict.model_fit` docs, and it seems like the latter method is the one we'd be directly using.
|
@dajmcdon I addressed some comments but still have a few pending questions up above. The new changes might be worth a look... they don't seem too elegant as (i) they involve passing around type, opts, ... in many places but not everywhere, and (ii) because it's actually forwarding stuff in previously-unused ...; it was a quick and NSE-compatible way to do things, but I'm not sure we want to sacrifice parts of the dots "namespace" in so many places. |
dajmcdon
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Hi @brookslogan this all looks good to me. Feel free to merge.
Since epiprocess#472, as_epi_df.<decayed epi_df> will ignore the geo and time type args and re-infer them, plus emit a warning if these args were provided. We could `dplyr_reconstruct` to go back to trusting `meta` instead of re-inferring, but since baking could plausibly (but likely rarely) change them, don't. - Pre-epiprocess#472, this should be a bugfix in any such rare cases. - Post-epiprocess#472, this should remove warning spam.
|
@dajmcdon tests were failing due to an epiprocess update; I've slightly changed bake behavior in a way I think is a rare bugfix. Since bake-ing's pretty key, I'll leave it to you to merge. |
Workaround for epiprocess#493.
dajmcdon
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
dajmcdon.
DESCRIPTIONandNEWS.md.Always increment the patch version number (the third number), unless you are
making a release PR from dev to main, in which case increment the minor
version number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
0.7.2, then write your changes under the 0.8 heading).
epiprocessversion in theDESCRIPTIONfile ifepiprocesssoonepipredictandepiprocessChange explanations for reviewer
This uses
rlang::inject()to splat in the stored dots list. Some validation and tests have also been added, plus following @dajmcdon's suggested correction to an@inheritParamsdirective.Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
layer_predict()to pass along...#46